Skip to content

fix view bugs in vam/expr.Dequiet #6957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwt merged 1 commit into from
May 18, 2026
+5 −3
Merged

fix view bugs in vam/expr.Dequiet #6957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions runtime/vam/expr/quiet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func NewDequiet(sctx *super.Context, expr Evaluator) Evaluator {

func (d *Dequiet) Eval(this vector.Any) vector.Any {
return vector.Apply(true, func(vecs ...vector.Any) vector.Any {
vec := vector.Under(vecs[0])
vec := vecs[0]
if vec.Kind() == vector.KindRecord {
vec = d.rec(vec)
}
Expand All @@ -40,15 +40,17 @@ func (d *Dequiet) Eval(this vector.Any) vector.Any {
}

func (d *Dequiet) rec(vec vector.Any) vector.Any {
vec = vector.Under(vec)
origVec := vec
var index []uint32
if view, ok := vec.(*vector.View); ok {
index = view.Index
vec = view.Any
}
var vecs []vector.Any
rec := vector.Under(vec).(*vector.Record)
rec := vec.(*vector.Record)
if len(rec.Fields) == 0 {
return vec
return origVec
}
for _, field := range rec.Fields {
vec := field
Expand Down
Loading