ztest: use storage.InternalEngine for SPQ-style tests#6962
Merged
Conversation
When ztest executes a SPQ-style test, it provides the test's input to the runtime by passing an sio.Reader to runtime.CompileQuery, prompting the compiler to prepend an ast.DefaultScan to the test's AST to signal to the runtime that the flowgraph should read from the sio.Reader. If the same test is executed via the super command, the input will be read via an ast.FileScan, and this different mechanism can produce differently structured vectors. To eliminate that difference, add pkg/storage.InternalEngine and use it in ztest.runInternal to allow SPQ-style tests to read their input from an ast.FileScan rather than an ast.DefaultScan.
mccanne
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ztest executes a SPQ-style test, it provides the test's input to the runtime by passing an sio.Reader to runtime.CompileQuery, prompting the compiler to prepend an ast.DefaultScan to the test's AST to signal to the runtime that the flowgraph should read from the sio.Reader. If the same test is executed via the super command, the input will be read via an ast.FileScan, and this different mechanism can produce differently structured vectors. To eliminate that difference, add pkg/storage.InternalEngine and use it in ztest.runInternal to allow SPQ-style tests to read their input from an ast.FileScan rather than an ast.DefaultScan.