Skip to content

🔥 Simplify PR template#24

Merged
LegeBeker merged 7 commits intomainfrom
simplify-pr-template
Dec 24, 2025
Merged

🔥 Simplify PR template#24
LegeBeker merged 7 commits intomainfrom
simplify-pr-template

Conversation

@LegeBeker
Copy link
Copy Markdown
Member

@LegeBeker LegeBeker commented Oct 6, 2025

🔍 Samenvatting

Deze PR zorgt dat er maar 1 PR template is, omdat dit de enige is die wordt gebruikt.

rickyheijnen and others added 2 commits October 5, 2025 21:30
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@LegeBeker LegeBeker self-assigned this Oct 6, 2025
@LegeBeker LegeBeker added the type: 📝 documentation Improvements or additions to documentation label Oct 6, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 6, 2025

Walkthrough

Pull request consolidates multiple Dutch-language PR templates into a unified template structure. The main template file is updated with Dutch headers and a standardized checklist, while five specific template files and template content are deleted.

Changes

Cohort / File(s) Summary
Main PR Template Update
\.github/PULL_REQUEST_TEMPLATE\.md
Replaces English header with Dutch "## 🔍 Samenvatting", adds "## 📝 Beschrijving" section, removes "General Templates" and "Specific templates" sections with associated links, and replaces template link blocks with Dutch three-item checklist (local testing, tests added/updated, documentation updated if needed).
Template Files Deleted
\.github/PULL_REQUEST_TEMPLATE/documentation\.md, feature\.md, fix\.md, general-extended\.md, general-small\.md, refactor\.md
Six template files removed, including content for documentation, feature, fix, general-extended, general-small, and refactor templates. All contained Dutch-language PR guidance sections but are consolidated into the main template.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Simplify PR template' accurately describes the main change: consolidating multiple PR templates into a single template.
Description check ✅ Passed The description explains the purpose of the change: consolidating to one PR template because only one is used, which is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch simplify-pr-template

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f62fba and bae0758.

📒 Files selected for processing (1)
  • .github/PULL_REQUEST_TEMPLATE.md
🧰 Additional context used
🪛 GitHub Actions: Shared Lint Markdown Workflow
.github/PULL_REQUEST_TEMPLATE.md

[error] 1-1: MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading

🪛 GitHub Check: Lint Markdown
.github/PULL_REQUEST_TEMPLATE.md

[failure] 1-1: First line in a file should be a top-level heading
shared/.github/PULL_REQUEST_TEMPLATE.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## 🔍 Samenvatting"] https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md041.md


[failure] 1-1: First line in a file should be a top-level heading
.github/PULL_REQUEST_TEMPLATE.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## 🔍 Samenvatting"] https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md041.md

🪛 LanguageTool
.github/PULL_REQUEST_TEMPLATE.md

[grammar] ~13-~13: Fout gevonden
Context: ...✅ Checklist - [ ] Code is lokaal getest - [ ] Tests zijn toegevoegd/aangepast - [ ...

(QB_NEW_NL_OTHER_ERROR_IDS_REPLACEMENT_ORTHOGRAPHY_SPELLING)


[grammar] ~14-~14: Fout gevonden
Context: ...st - [ ] Tests zijn toegevoegd/aangepast - [ ] Documentatie bijgewerkt (indien nodi...

(QB_NEW_NL_OTHER_ERROR_IDS_REPLACEMENT_ORTHOGRAPHY_SPELLING)


Comment @coderabbitai help to get the list of available commands and usage tips.

@LegeBeker LegeBeker marked this pull request as ready for review December 24, 2025 13:34
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
.github/workflows/label-sync.yml (1)

1-2: Optional: Remove unnecessary YAML frontmatter and blank line.

The YAML frontmatter (---) on line 1 and the blank line on line 2 are optional and can be removed for cleaner formatting in GitHub Actions workflows.

🔎 Proposed cleanup
----
-
 name: Label Sync
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40868b9 and 5f62fba.

📒 Files selected for processing (8)
  • .github/PULL_REQUEST_TEMPLATE.md
  • .github/PULL_REQUEST_TEMPLATE/documentation.md
  • .github/PULL_REQUEST_TEMPLATE/feature.md
  • .github/PULL_REQUEST_TEMPLATE/fix.md
  • .github/PULL_REQUEST_TEMPLATE/general-extended.md
  • .github/PULL_REQUEST_TEMPLATE/general-small.md
  • .github/PULL_REQUEST_TEMPLATE/refactor.md
  • .github/workflows/label-sync.yml
💤 Files with no reviewable changes (6)
  • .github/PULL_REQUEST_TEMPLATE/documentation.md
  • .github/PULL_REQUEST_TEMPLATE/general-small.md
  • .github/PULL_REQUEST_TEMPLATE/general-extended.md
  • .github/PULL_REQUEST_TEMPLATE/feature.md
  • .github/PULL_REQUEST_TEMPLATE/fix.md
  • .github/PULL_REQUEST_TEMPLATE/refactor.md
🧰 Additional context used
🪛 GitHub Actions: Shared Lint Markdown Workflow
.github/PULL_REQUEST_TEMPLATE.md

[error] 1-1: markdownlint: MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading. Update the first line to be a level-1 heading.

🪛 GitHub Check: Lint Markdown
.github/PULL_REQUEST_TEMPLATE.md

[failure] 1-1: First line in a file should be a top-level heading
shared/.github/PULL_REQUEST_TEMPLATE.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## 🔍 Samenvatting"] https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md041.md


[failure] 1-1: First line in a file should be a top-level heading
.github/PULL_REQUEST_TEMPLATE.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## 🔍 Samenvatting"] https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md041.md

🪛 LanguageTool
.github/PULL_REQUEST_TEMPLATE.md

[grammar] ~17-~17: Fout gevonden
Context: ...✅ Checklist - [ ] Code is lokaal getest - [ ] Tests zijn toegevoegd/aangepast - [ ...

(QB_NEW_NL_OTHER_ERROR_IDS_REPLACEMENT_ORTHOGRAPHY_SPELLING)


[grammar] ~18-~18: Fout gevonden
Context: ...st - [ ] Tests zijn toegevoegd/aangepast - [ ] Documentatie bijgewerkt (indien nodi...

(QB_NEW_NL_OTHER_ERROR_IDS_REPLACEMENT_ORTHOGRAPHY_SPELLING)

🔇 Additional comments (1)
.github/workflows/label-sync.yml (1)

5-13: LGTM! Appropriate triggers and permissions.

The event triggers (schedule, workflow_dispatch, repository_dispatch) are well-suited for a label-sync workflow, and the issues: write permission is correctly specified for label operations.

@LegeBeker LegeBeker merged commit e66d583 into main Dec 24, 2025
2 of 3 checks passed
@LegeBeker LegeBeker deleted the simplify-pr-template branch December 24, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: 📝 documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants