🔧 Redefine size label descriptions from time to complexity#25
🔧 Redefine size label descriptions from time to complexity#25rickyheijnen merged 1 commit intomainfrom
Conversation
WalkthroughUpdated the size/effort label descriptions in the labels configuration file, replacing time-estimate-based text with qualitative complexity assessments for XS, S, M, L, and XL categories. No structural or behavioral modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
labels/general.yml (1)
64-84: Consider parallel structure for consistency (optional).The descriptions use slightly different patterns: XS/S say "work," M/L say "complexity," and XL is prescriptive. While the current descriptions are clear and effective, using a more parallel structure could enhance consistency. For example:
- XS: "Trivial. Clear, low risk, no coordination needed."
- S: "Simple. Known pattern, low uncertainty."
- M: "Moderate. Multiple steps or small decisions."
- L: "Complex. Multiple parts, risks or dependencies."
- XL: "Too complex or unclear. Split or run a spike first."
However, the current wording is already clear and functional, so this is just a style consideration.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
labels/general.yml
🔇 Additional comments (1)
labels/general.yml (1)
64-84: Excellent alignment with PR objectives.The updated size label descriptions successfully remove time-based definitions and focus on qualitative assessments of complexity, risk, and uncertainty. The progression from XS to XL is clear and logical, and the XL description provides actionable guidance ("Split or run a spike first") that aligns well with the spike label defined later in this file.
🔍 Samenvatting
Deze PR herdefiniëert de size labels van tijd naar complexiteit
Waarom
Onze size labels waren gekoppeld aan tijd (uren/minuten).
Dat zorgt voor schijnnauwkeurigheid, onnodige discussies en defensief inschatten.
We stappen daarom over naar sizes op basis van complexiteit en onzekerheid, niet op tijd.
Dit past beter bij hoe we werken en hoe ons werk zich in de praktijk gedraagt.
Wat verandert
Tijdsaanduidingen zijn verwijderd uit alle size labels
Sizes beschrijven nu:
size: XLis expliciet een signaal geworden:De labels zelf blijven hetzelfde (
XS / S / M / L / XL), alleen de betekenis verandert.