Skip to content

🔧 Redefine size label descriptions from time to complexity#25

Merged
rickyheijnen merged 1 commit intomainfrom
config/improve-size-label-desc
Dec 24, 2025
Merged

🔧 Redefine size label descriptions from time to complexity#25
rickyheijnen merged 1 commit intomainfrom
config/improve-size-label-desc

Conversation

@rickyheijnen
Copy link
Copy Markdown
Member

@rickyheijnen rickyheijnen commented Dec 24, 2025

🔍 Samenvatting

Deze PR herdefiniëert de size labels van tijd naar complexiteit

Waarom

Onze size labels waren gekoppeld aan tijd (uren/minuten).
Dat zorgt voor schijnnauwkeurigheid, onnodige discussies en defensief inschatten.

We stappen daarom over naar sizes op basis van complexiteit en onzekerheid, niet op tijd.
Dit past beter bij hoe we werken en hoe ons werk zich in de praktijk gedraagt.


Wat verandert

  • Tijdsaanduidingen zijn verwijderd uit alle size labels

  • Sizes beschrijven nu:

    • complexiteit
    • risico
    • mate van duidelijkheid
  • size: XL is expliciet een signaal geworden:

    • te onzeker of te groot
    • eerst opsplitsen of een spike uitvoeren
    • niet direct bouwen

De labels zelf blijven hetzelfde (XS / S / M / L / XL), alleen de betekenis verandert.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 24, 2025

Walkthrough

Updated the size/effort label descriptions in the labels configuration file, replacing time-estimate-based text with qualitative complexity assessments for XS, S, M, L, and XL categories. No structural or behavioral modifications.

Changes

Cohort / File(s) Summary
Label Configuration Updates
labels/general.yml
Modified size label descriptions: replaced explicit time estimates and durations with qualitative phrases describing complexity levels and guidance (e.g., "Trivial work. Clear, low risk, no coordination needed." for XS, "High complexity. Multiple parts, risks or dependencies." for L). Changes applied to five size categories; label names and structure unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale and details of the size label redefinition, despite being in Dutch.
Title check ✅ Passed The title 'Redefine size label descriptions from time to complexity' accurately and concisely captures the main change: removing time-based definitions from size labels and replacing them with complexity-focused descriptions.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch config/improve-size-label-desc

Comment @coderabbitai help to get the list of available commands and usage tips.

@rickyheijnen rickyheijnen self-assigned this Dec 24, 2025
@rickyheijnen rickyheijnen added the type: ✨ feature Request or addition of new functionality label Dec 24, 2025
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
labels/general.yml (1)

64-84: Consider parallel structure for consistency (optional).

The descriptions use slightly different patterns: XS/S say "work," M/L say "complexity," and XL is prescriptive. While the current descriptions are clear and effective, using a more parallel structure could enhance consistency. For example:

  • XS: "Trivial. Clear, low risk, no coordination needed."
  • S: "Simple. Known pattern, low uncertainty."
  • M: "Moderate. Multiple steps or small decisions."
  • L: "Complex. Multiple parts, risks or dependencies."
  • XL: "Too complex or unclear. Split or run a spike first."

However, the current wording is already clear and functional, so this is just a style consideration.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40868b9 and dcde443.

📒 Files selected for processing (1)
  • labels/general.yml
🔇 Additional comments (1)
labels/general.yml (1)

64-84: Excellent alignment with PR objectives.

The updated size label descriptions successfully remove time-based definitions and focus on qualitative assessments of complexity, risk, and uncertainty. The progression from XS to XL is clear and logical, and the XL description provides actionable guidance ("Split or run a spike first") that aligns well with the spike label defined later in this file.

@rickyheijnen rickyheijnen changed the title 🔧 Modify size label descriptions to not define time 🔧 Redefine size label descriptions to not define time Dec 24, 2025
@rickyheijnen rickyheijnen changed the title 🔧 Redefine size label descriptions to not define time 🔧 Redefine size label descriptions from time to complexity Dec 24, 2025
@rickyheijnen rickyheijnen merged commit 6637aa6 into main Dec 24, 2025
2 of 3 checks passed
@rickyheijnen rickyheijnen deleted the config/improve-size-label-desc branch December 24, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: ✨ feature Request or addition of new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant