copilot-adapter: expose submit_outcome reason as a step output#140
Merged
Conversation
The copilot adapter previously emitted only an outcome from each step, leaving the model's `reason` argument visible only as an adapter event that downstream workflow steps could not reference. Surface it as the `reason` step output so HCL expressions can read `steps.<name>.reason`. Failure paths (reprompt exhaustion, permission denial, max_turns) emit no outputs.
brokenbot
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecuteResultonly carriedOutcome— thereasonargument the model passes tosubmit_outcomewas visible only as an adapter event and could not be referenced from downstream workflow expressions.ExecuteResult.Outputswith{"reason": <model-supplied reason>}on successful finalization so HCL can readsteps.<step_name>.reason. Failure paths (reprompt exhaustion, permission denial,max_turnsreached) emit no outputs, matching prior behavior.docs/adapters.mdunder "Outcome Finalization".Test plan
go test ./cmd/criteria-adapter-copilot/ -count=1— full adapter suite passes.TestAwaitOutcome_ReasonInOutputsasserts the reason surfaces in the result's outputs end-to-end throughExecute.steps.<name>.reasonin a downstream step expression.