Skip to content

fix: sync registry_generator.py with async event handler changes#15

Open
yie1d wants to merge 2 commits intobrowser-use:mainfrom
yie1d:main
Open

fix: sync registry_generator.py with async event handler changes#15
yie1d wants to merge 2 commits intobrowser-use:mainfrom
yie1d:main

Conversation

@yie1d
Copy link
Copy Markdown

@yie1d yie1d commented Jan 6, 2026

  • This fixes the generator to match the changes made in commit 4fed163, which added async event handler support to cdp/registry.py but didn't update the generator. Without this fix, regenerating the code would revert the async handler changes and cause runtime errors.

Summary by cubic

Updates registry_generator.py to generate an async handle_event that matches the async handler support in cdp/registry.py, preventing regenerated code from breaking at runtime.

  • Bug Fixes
    • Make handle_event async and await coroutine handlers; call sync handlers directly.
    • Detect async handlers with inspect.iscoroutinefunction to preserve correct behavior during code generation.

Written for commit 9a1c62d. Summary will update on new commits.

- This fixes the generator to match the changes made in commit 4fed163,
which added async event handler support to cdp/registry.py but didn't
update the generator. Without this fix, regenerating the code would
revert the async handler changes and cause runtime errors.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@yie1d
Copy link
Copy Markdown
Author

yie1d commented Jan 6, 2026

fix #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant