Edit the introduction for clarity#26
Open
colindecarlo wants to merge 1 commit intobrowserify:masterfrom
Open
Conversation
The last sentence of the final paragraph of the introduction was mangled by an edit gone wrong. This change completes the original intended edit.
stevemao
reviewed
Nov 1, 2017
| Increasingly, people are publishing modules to npm which are intentionally | ||
| designed to work in both node and in the browser using browserify and many | ||
| packages on npm are intended for use in just the browser. | ||
| designed to work in both node and in the browser. Using browserify |
Member
There was a problem hiding this comment.
Did you miss "and many packages on npm are intended for use in just the browser."?
Author
There was a problem hiding this comment.
unfortunately I don't have the same context now as I did 3 years ago when I originally made this PR so I can't really say for sure if I missed that part. What I can say is I must have thought the sentence was confusing enough to warrant a helpful drive by PR. Thanks for getting to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last sentence of the final paragraph of the introduction was mangled by an edit gone wrong. This change completes the original intended edit.