feat(agent): display model name at end of completed chat session#1000
Open
Aarjav Jain (A2rjav) wants to merge 1 commit into
Open
feat(agent): display model name at end of completed chat session#1000Aarjav Jain (A2rjav) wants to merge 1 commit into
Aarjav Jain (A2rjav) wants to merge 1 commit into
Conversation
Closes browseros-ai#883 Users had no in-UI way to confirm which provider/model handled a given session, which made comparing model behaviour and debugging unexpected output harder than it needed to be. - New SessionCompletedFooter component shows "Session completed with <model>" beneath the last assistant message once status transitions to 'ready' and there is no active chat or agent-URL error - formatSessionCompletedLabel resolves the best human-readable label: Provider.name for LLM targets, "<adapterName> · <modelLabel>" for ACP targets, with graceful fallbacks when ACP metadata is partial - Unit tests cover undefined provider, llm targets, full and partial ACP targets, and both fallback paths
Contributor
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #883
Adds a small "Session completed with " footer that renders beneath the conversation once an assistant turn finishes. Users had no in-UI signal of which provider/model handled a given session, which made comparing model behaviour and debugging unexpected output harder than necessary.
Changes
New component:
apps/agent/entrypoints/sidepanel/index/SessionCompletedFooter.tsxformatSessionCompletedLabelhelper resolves the best label:Provider.name(the user's configured display name)<adapterName> · <modelLabel>(e.g.Codex · gpt-4-turbo)Provider.name)nullwhen the provider is undefined or no label can be resolvedWire-up:
apps/agent/entrypoints/sidepanel/index/Chat.tsx<main>after the error bannersmessages.length > 0 && status === 'ready' && !chatError && !agentUrlErrorTests:
apps/agent/entrypoints/sidepanel/index/SessionCompletedFooter.test.tsTest plan
bun test apps/agent/entrypoints/sidepanel/index/SessionCompletedFooter.test.ts— 6/6 passbun test apps/agent/entrypoints/sidepanel/index/— 18/18 pass (no regressions in adjacent files)bunx @biomejs/biome checkon the three touched files — clean<adapter> · <model>Visual