fix(agent): keep ChatSessionProvider mounted across /home/* navigations#943
Open
Aarjav Jain (A2rjav) wants to merge 1 commit into
Open
Conversation
Contributor
|
PR author is not in the allowed authors list. |
Contributor
|
All contributors have signed the CLA. Thank you! |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Closes browseros-ai#927 ChatSessionProvider was conditionally rendered only when shouldUseChatSession() returned true (i.e. only at /home/chat). Any navigation away from that route unmounted the provider and destroyed the in-memory useChat message state. Now ChatSessionProvider unconditionally wraps all /home/* routes so messages survive sub-route changes. Removes the dead shouldUseChatSession helper, useChatSessionOnHome prop, and associated tests.
Aarjav Jain (A2rjav)
force-pushed
the
fix/927-chat-messages-persist-navigation
branch
from
bfd6df2 to
0ab1089
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #927
ChatSessionProviderwas conditionally mounted — only rendered whenshouldUseChatSession()returnedtrue(i.e. only on/home/chat). Any navigation away from that route unmounted the provider and destroyed the in-memoryuseChatmessage state. Returning to chat started a fresh session with no history.ChatSessionProvidernow unconditionally wraps all/home/*routesshouldUseChatSessionhelper functionuseChatSessionOnHomeprop fromNewTabLayoutTest plan
/home/chat, send a message/home/skills,/home/memory)/home/chat— previous messages should still be visiblebun run typecheck)