chore: unship Memory and Soul#958
Conversation
|
Greptile (@greptileai) review |
|
Claude (@claude) review |
|
Claude finished Nikhil (@shadowfax92)'s task in 2m 41s —— View job Code Review: chore/unship Memory and SoulTasks
SummaryA clean, well-scoped unship. The PR deletes all global Memory/Soul UI and backend surfaces atomically, correctly preserves the ACPX/OpenClaw adapter paths, and fixes up analytics step numbering, route fallbacks, and test expectations. No dangling references found. ObservationsCorrect / Looks Good
Minor Notes1. Sanitization regex no longer strips
// before
/<\/?(?:selected_text|USER_QUERY|page_context|AGENT_PROMPT|soul|memory_and_identity|security|workspace)[^>]*>/gi
// after
/<\/?(?:selected_text|USER_QUERY|page_context|AGENT_PROMPT|security|workspace)[^>]*>/giSince neither 2. Duplicate files still present (pre-existing, not introduced here)
3. Test count comment now stale
4. Leftover memory/soul files on disk for existing users Existing installs will still have VerdictApproved with the notes above. All surface areas are consistently cleaned up. The four observations above are minor — none are blockers. The test plan in the PR description ( |
✅ Tests passed — 1124/1128
|
Greptile SummaryThis PR removes the global Memory and Soul feature surfaces — pages, sidebar entries, onboarding steps, API routes, AI SDK tools, and all prompt guidance — while deliberately preserving the separate ACPX/OpenClaw adapter path that has its own runtime memory/soul handling.
Confidence Score: 5/5Safe to merge — the change is a clean, self-consistent removal with no loose ends left behind. All call sites (routes, sidebar, onboarding, prompt builder, tool registry, analytics events, startup seeding, shared constants) are updated in lock-step. The sanitization regex in format-message.ts is correctly trimmed to only the tags still used as prompt delimiters. Onboarding step numbers and analytics events are renumbered consistently. Tests are properly replaced rather than simply deleted. The OpenClaw/ACPX adapter path is explicitly preserved by keeping its own memory/soul runtime independent of the deleted shared code. No files require special attention. The monitor-page SKILL.md now directs the agent to use workspace files for baseline storage, which is a reasonable fallback, but users on sessions without a workspace will see a degraded monitoring experience (baseline returned in chat rather than persisted). Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["User visits /home/memory or /home/soul"] --> B{Route registered?}
B -- "Before PR" --> C["MemoryPage / SoulPage rendered"]
B -- "After PR" --> D["Route missing — falls through to 404 fallback"]
E["settings/soul redirect"] --> F{Target}
F -- "Before PR" --> G["/home/soul"]
F -- "After PR" --> H["/settings/ai"]
I[AiSdkAgent builds toolset] --> J{Memory tools?}
J -- "Before PR" --> K["6 tools added: memory_search, memory_write, memory_read_core, memory_update_core, soul_read, soul_update"]
J -- "After PR" --> L["No memory tools"]
M[Agent system prompt] --> N{Memory and Identity section?}
N -- "Before PR" --> O["Full section: SOUL.md, Core/Daily tiers, tool guidance"]
N -- "After PR" --> P["Section removed entirely"]
Q[Onboarding steps] --> R{Step order}
R -- "Before PR" --> S["1 Welcome - 2 Soul - 3 Connect Apps - 4 Sign In"]
R -- "After PR" --> T["1 Welcome - 2 Connect Apps - 3 Sign In"]
Reviews (1): Last reviewed commit: "chore: unship memory and soul" | Re-trigger Greptile |
1 participant
Summary
Design
This unships the global Memory/Soul feature by deleting the shipped UI and backend surfaces rather than hiding them behind another runtime gate. The agent prompt and toolset no longer advertise unavailable Memory/Soul behavior, while onboarding step numbering and route fallbacks are adjusted so removed paths fall back to supported screens.
Test plan