Conversation
|
Example of CRC problem:
EDIT: I misunderstood how the CRC function works. Apparently one either needs to append two zero's at the end to get the CRC correctly calculated and returned, OR one can already put in the actual CRC, and then he CRC function will return '0' if the CRC is correct. Thus: The original code did this correctly - I will restore this shorthly. |
|
Hi @adabrandt, sorry I haven't found any other way to get in touch with you... I really like that you implemented the For more info, you can find my email on my GitHub profile page, feel free to contact me, thanks! |
This pull request adds support to read out the Kamstrup Multical 21 water meter using the optical eye from https://wiki.volkszaehler.org/hardware/controllers/ir-schreib-lesekopf (I used the USB version).
Notes about the multical 21 interface:
0x80 ...) is fed back to the sender first, and needs to be ignored before processing the actual response (0x40 ...). This seems different from the other Kamstrup devices already supported (as the code did not seem to be able to handle that).Open points:
CRC of the response seems not to be correct. This does not matter, as we dont need it, but is still strange. It might indicate a problem with the CRC calculation.All comments welcome. I tried to stay as close as possible to the original code, with the exception of factoring out the common code between
readvarandreadvar_multipleinto a newprocess_responsefunction.