Skip to content

fix/bug-in-graffiti#279

Merged
BlobMaster41 merged 3 commits intomainfrom
test/mainnet45
Apr 3, 2026
Merged

fix/bug-in-graffiti#279
BlobMaster41 merged 3 commits intomainfrom
test/mainnet45

Conversation

@BlobMaster41
Copy link
Copy Markdown
Contributor

@BlobMaster41 BlobMaster41 commented Apr 3, 2026

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Performance improvement
  • Consensus change (changes that affect state calculation or validation)
  • Refactoring (no functional changes)
  • Documentation update
  • CI/CD changes
  • Dependencies update

Checklist

Build & Tests

  • npm install completes without errors
  • npm run build completes without errors
  • npm test passes all tests

Code Quality

  • Code follows the project's coding standards
  • No new compiler warnings introduced
  • Error handling is appropriate
  • Logging is appropriate for debugging and monitoring

Documentation

  • Code comments added for complex logic
  • Public APIs are documented
  • README updated (if applicable)

Security

  • No sensitive data (keys, credentials) committed
  • No new security vulnerabilities introduced
  • RPC endpoints properly authenticated
  • Input validation in place for external data

OP_NET Node Specific

  • Changes are compatible with existing network state
  • Consensus logic changes are documented and tested
  • State transitions are deterministic
  • WASM VM execution is reproducible across nodes
  • P2P protocol changes are backward-compatible (or migration planned)
  • Database schema changes include migration path
  • Epoch finality and PoC/PoW logic unchanged (or documented if changed)

Testing

Consensus Impact

Related Issues


By submitting this PR, I confirm that my contribution is made under the terms of the project's license.

Unify graffiti maxLength retrieval and tighten parsing logic in SharedInteractionParameters: use OPNetConsensus.consensus.EPOCH.GRAFFITI_LENGTH as maxLength, remove debug logging, read only the remaining bytes for graffiti when the patch is active (readBytes(bytesLeft)), and use the same maxLength check in the legacy branch. Also add an inline comment to RoswellConsensus PATCH block height (943417n //943432n) as a note. These changes prevent incorrect fixed-length reads/padding and remove leftover debug output.
@BlobMaster41 BlobMaster41 changed the title Test/mainnet45 fix/bug-in-graffiti Apr 3, 2026
@BlobMaster41 BlobMaster41 merged commit 6e24c80 into main Apr 3, 2026
8 checks passed
@BlobMaster41 BlobMaster41 deleted the test/mainnet45 branch April 3, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant