Conversation
- re-enable responses path for streaming when use_responses is enabled\n- normalize responses streaming tool-call events (arguments + output_item)\n- preserve call_id mapping and support usage from in_progress/failed/incomplete events\n- convert tool schemas for non-stream responses API calls\n- add sync/async parity matrix tests for use_responses=false/true and refactor test fixtures for maintainability
yihong0618
approved these changes
Mar 2, 2026
frostming
reviewed
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR restores behavioral parity between
chat completionsandresponseswhenuse_responses=true, andimproves maintainability.
What changed
ChatClientinto dedicated adapters:clients/parsing/completion.pyclients/parsing/responses.pyclients/parsing/common.pyreasoning_efforthandling:reasoning.effortfor responses (explicitreasoningstill wins)stream_options.include_usage=truefor completion streaming when not explicitly set.Commits included
d8c3349fix: restore responses parity across main pathsde41fa9refactor: split chat parsing into completion and responses adaptersde27115fix: align reasoning and stream usage defaults across chat and responses