Merged
Conversation
jhump
force-pushed
the
jh/re-enable-checklocks
branch
from
abc22cd to
fc6aec2
Compare
rodaine
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was disabled back when we upgraded to Go v1.23, because checklocks at the time had not yet made changes/fixes so it was compatible with Go v1.23. We are now on Go v1.24 (and need to move to Go v1.25 soon since it has been out for months), and the latest checklocks works fine with the newer Go versions. So it is past time to re-enable these checks.