Skip to content

update parse64 parsing from 32 to 64 bit #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KaustubhKhulbe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update parse64 parsing from 32 to 64 bit #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/tdp/thunks/oneof.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ func parseOneofVarint32(p1 vm.P1, p2 vm.P2) (vm.P1, vm.P2) {
//go:nosplit
func parseOneofVarint64(p1 vm.P1, p2 vm.P2) (vm.P1, vm.P2) {
xunsafe.ByteStore(p2.Message(), p2.Field().Offset.Bit, p2.Field().Offset.Number)
return parseVarint32(p1, p2)
return parseVarint64(p1, p2)
}

//go:nosplit
Expand All @@ -242,7 +242,7 @@ func parseOneofZigZag32(p1 vm.P1, p2 vm.P2) (vm.P1, vm.P2) {
//go:nosplit
func parseOneofZigZag64(p1 vm.P1, p2 vm.P2) (vm.P1, vm.P2) {
xunsafe.ByteStore(p2.Message(), p2.Field().Offset.Bit, p2.Field().Offset.Number)
return parseZigZag32(p1, p2)
return parseZigZag64(p1, p2)
}

//go:nosplit
Expand Down