Fix: pass in the repo root for the 'dir' argument #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tools that run bazel commands from within
bazel runtheBUILD_WORKSPACE_DIRECTORYwill be set and then in this code the directory will eventually be set to the top level repo root. An example of a tool that this can happen to is the gopackagesdriver in rules_go.This results in error messages like:
By passing in additional argument it explicitly sets the
dirto the directory of the repo. Gazelle itself does something similar