Update command line to handle nested json objects#7
Update command line to handle nested json objects#7jacalata wants to merge 38 commits intobunkat:masterfrom
Conversation
to run from the command line I had to start with 'node'. I could be missing something about the usual workflow as I'm pretty new to node plugins.
change from simple iteration over input to a recursive call
|
Thanks for the pull request. Would you be able to add a test case for nested objects as well? |
|
What kind of test case were you thinking? The only place that json objects are handled are within the command line program, which doesn't currently have test cases. I added a nested object to the example.json file, would you prefer it to be separate eg example-nested.json? |
|
Ah, I didn't look at the pull request carefully enough. By only updating the command line tool, this functionality isn't available to tools using the API. I thought you had added a new function to I probably won't merge this change as is, but if you wanted to refactor the code a little that would be great. Otherwise, I'll do the refactor the next time I touch the code. Sorry about the confusion. |
Recursively search whole object and pseudolocalize each string value.
This reverts commit 7b419a6.
changed author name (included credit to bunkat)
Extend with Space issue
Updated Extend section in Readme
- Migrate additional tasks to npm scripts - Remove files related to tasks that no longer exist: - coverage - component.json
Update build process (remove MAKE and add npm scripts)
Multi delimiter support
I missed this before when I was doing cleanup on the old build system.
Remove one more reference to 'pseudoloc.cov'
- Changed padding characters so that they are all supplementary characters (above U+FFFF). Previously only one of the padding characters was above U+FFFF. This change guarantees that all padding characters are supplementary. - Changed the test case to reflect this. Previous test case actually failed on some runs - it was expecting a length of 32, which wasn't the case if the algorithm chose the single supplementary character. (JavaScript counts supplementary character as being of length 2.) - Fixed typo in Readme
Fixes to padding algorithm and tests
so that `pseudoloc` is available on the command-line after a npm install. re: bunkat#11
Add bin configuration to package.json
8 participants
change from simple iteration over input to a recursive call