Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AI Agent component to wire Spring AI tool-calling support via ToolCallingManager/ToolCallAdvisor, and introduces explicit advisor ordering so chat-memory advisors run with a defined precedence.
Changes:
- Inject
ToolCallingManagerthrough the AI Agent component handler/actions and addToolCallAdvisorto the advisor chain. - Define explicit advisor ordering for chat-memory advisors (Prompt/VectorStore variants).
- Update unit tests to match new constructors/signatures.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/libs/modules/components/ai/agent/src/test/java/com/bytechef/component/chat/AiAgentComponentHandlerTest.java | Updates handler construction for the new constructor signature. |
| server/libs/modules/components/ai/agent/src/test/java/com/bytechef/component/ai/agent/action/AbstractAiAgentChatActionTest.java | Adds ToolCallingManager mocking and updates action construction. |
| server/libs/modules/components/ai/agent/src/main/java/com/bytechef/component/ai/agent/AiAgentComponentHandler.java | Injects ToolCallingManager and wires it into chat/stream chat actions. |
| server/libs/modules/components/ai/agent/src/main/java/com/bytechef/component/ai/agent/action/AiAgentStreamChatAction.java | Threads ToolCallingManager into the stream chat action. |
| server/libs/modules/components/ai/agent/src/main/java/com/bytechef/component/ai/agent/action/AiAgentChatAction.java | Threads ToolCallingManager into the chat action and updates factory method signature. |
| server/libs/modules/components/ai/agent/src/main/java/com/bytechef/component/ai/agent/action/AbstractAiAgentChatAction.java | Adds ToolCallAdvisor wiring and adjusts advisor composition around chat memory. |
| server/libs/modules/components/ai/agent/chat-memory/chat-memory-vectorstore/src/main/java/com/bytechef/component/ai/chat/memory/cluster/VectorStoreChatMemory.java | Sets explicit advisor order for vectorstore chat memory advisor. |
| server/libs/modules/components/ai/agent/chat-memory/chat-memory-redis/src/main/java/com/bytechef/component/ai/agent/chat/memory/redis/cluster/RedisChatMemory.java | Sets explicit advisor order for redis chat memory advisor. |
| server/libs/modules/components/ai/agent/chat-memory/chat-memory-neo4j/src/main/java/com/bytechef/component/ai/agent/chat/memory/neo4j/cluster/Neo4jChatMemory.java | Sets explicit advisor order for neo4j chat memory advisor. |
| server/libs/modules/components/ai/agent/chat-memory/chat-memory-mongodb/src/main/java/com/bytechef/component/ai/agent/chat/memory/mongodb/cluster/MongoDbChatMemory.java | Sets explicit advisor order for mongodb chat memory advisor. |
| server/libs/modules/components/ai/agent/chat-memory/chat-memory-jdbc/src/main/java/com/bytechef/component/ai/agent/chat/memory/jdbc/cluster/JdbcChatMemory.java | Sets explicit advisor order for jdbc chat memory advisor. |
| server/libs/modules/components/ai/agent/chat-memory/chat-memory-in-memory/src/main/java/com/bytechef/component/ai/agent/chat/memory/memory/cluster/InMemoryChatMemory.java | Sets explicit advisor order for in-memory chat memory advisor. |
| server/libs/modules/components/ai/agent/chat-memory/chat-memory-cosmosdb/src/main/java/com/bytechef/component/ai/agent/chat/memory/cosmosdb/cluster/CosmosDbChatMemory.java | Sets explicit advisor order for cosmosdb chat memory advisor. |
| server/libs/modules/components/ai/agent/chat-memory/chat-memory-cassandra/src/main/java/com/bytechef/component/ai/agent/chat/memory/cassandra/cluster/CassandraChatMemory.java | Sets explicit advisor order for cassandra chat memory advisor. |
| server/libs/modules/components/ai/agent/chat-memory/chat-memory-builtin/src/main/java/com/bytechef/component/ai/agent/chat/memory/builtin/cluster/ChatMemory.java | Sets explicit advisor order for builtin chat memory advisor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…visor wiring Standardize (AiAgentToolFacade, ClusterElementDefinitionService, ToolCallingManager) across AiAgentChatAction.of, AiAgentStreamChatAction.of, their constructors, and the AiAgentComponentHandler call sites. Add tests asserting ToolCallAdvisor is present in the advisor list and that disableInternalConversationHistory() is applied only when a chat-memory advisor is configured. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.