-
Notifications
You must be signed in to change notification settings - Fork 44
release: componentize-js v0.19.0 #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vados-cosmonic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, we've got the StarlingMonkey update change in there now :)
tschneidereit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike that release-please doesn't have any support for providing free-form release notes in the changelog or otherwise manually edit its output—Wasmtime's release process is much nicer in this regard. But oh well, it's not the end of the world.
This is exactly why I don't use release-please! The release notes come together with a combination of https://github.com/bytecodealliance/ComponentizeJS/blob/main/cliff.toml We retain full control of what the release notes look like and can build any automation we want around it! I'm not sure exactly what you'd like to add but if you make an issue we can find some time to prioritize? |
|
Oh, my apologies! I completely mixed things up with the situation over in StarlingMonkey. Now I regret merging this already.
Had I known that that works, I'd have made edits to the changelog to highlight some key aspects of the StarlingMonkey update. And generally I think it'd be nice if we'd pen a quick user-friendly summary of a release before the list of merged PRs. Given that it seems like we can, I don't think there's a need to change anything about the automation. |
|
Yeah so dynamic injection of sections in the generated release notes is a bit more complex as right now the notes are generated fresh according to the template, both at release-prep time and actual release time. There are at least two options:
Best way to do either of these is probably by adding some more scripts that do the heavy lifting that we can call from CI. |
That's exactly what I would like to be able to do: make edit suggestions during the review of the release PR, merge those edits, and have the result be used as the release's actual changelog. |
|
Yup, definitely doable then -- just matter of adding a script to extract the markdown from the existing CHANGELOG file that gets committed when a PR like this one merges! |
This is a release prep branch for
componentize-jsreleasev0.19.0.To ensure this release is ready to be merged:
After this PR is merged tagging, artifact builds and releasing will run automatically.