Skip to content

Conversation

@jco-release-bot
Copy link
Collaborator

@jco-release-bot jco-release-bot commented Sep 8, 2025

This is a release prep branch for componentize-js release v0.19.0.

To ensure this release is ready to be merged:

  • Review updated CHANGELOG(s)

After this PR is merged tagging, artifact builds and releasing will run automatically.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, we've got the StarlingMonkey update change in there now :)

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike that release-please doesn't have any support for providing free-form release notes in the changelog or otherwise manually edit its output—Wasmtime's release process is much nicer in this regard. But oh well, it's not the end of the world.

@tschneidereit tschneidereit merged commit 979eeb1 into main Sep 8, 2025
17 checks passed
@tschneidereit tschneidereit deleted the prep-release-v0.19.0 branch September 8, 2025 12:06
@vados-cosmonic
Copy link
Contributor

I really dislike that release-please doesn't have any support for providing free-form release notes in the changelog or otherwise manually edit its output—Wasmtime's release process is much nicer in this regard. But oh well, it's not the end of the world.

This is exactly why I don't use release-please! The release notes come together with a combination of git-cliff and properly created tags/etc:

https://github.com/bytecodealliance/ComponentizeJS/blob/main/cliff.toml
https://github.com/bytecodealliance/ComponentizeJS/blob/main/.github/workflows/release.yml#L271
https://github.com/bytecodealliance/ComponentizeJS/blob/main/.github/workflows/release.yml#L285

We retain full control of what the release notes look like and can build any automation we want around it!

I'm not sure exactly what you'd like to add but if you make an issue we can find some time to prioritize?

@tschneidereit
Copy link
Member

Oh, my apologies! I completely mixed things up with the situation over in StarlingMonkey. Now I regret merging this already.

I'm not sure exactly what you'd like to add but if you make an issue we can find some time to prioritize?

Had I known that that works, I'd have made edits to the changelog to highlight some key aspects of the StarlingMonkey update. And generally I think it'd be nice if we'd pen a quick user-friendly summary of a release before the list of merged PRs. Given that it seems like we can, I don't think there's a need to change anything about the automation.

@vados-cosmonic
Copy link
Contributor

Yeah so dynamic injection of sections in the generated release notes is a bit more complex as right now the notes are generated fresh according to the template, both at release-prep time and actual release time. There are at least two options:

  1. If we wanted to influence what gets output in an automated manner we need probably a file in the repo or some dynamic pulling from the GitHub API (i.e. we could fish out a comment or some tagged portion of the PR description) to inject into the release notes.
  2. If we wanted, we can modify the generated Changelog file then update the automation to reuse the changelog section instead of re-generating it when creating the GH release.

Best way to do either of these is probably by adding some more scripts that do the heavy lifting that we can call from CI.

@tschneidereit
Copy link
Member

2. If we wanted, we can modify the generated Changelog file then update the automation to reuse the changelog section instead of re-generating it when creating the GH release.

That's exactly what I would like to be able to do: make edit suggestions during the review of the release PR, merge those edits, and have the result be used as the release's actual changelog.

@vados-cosmonic
Copy link
Contributor

Yup, definitely doable then -- just matter of adding a script to extract the markdown from the existing CHANGELOG file that gets committed when a PR like this one merges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants