Skip to content

Fix fuzzing with stream<char> #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Feb 9, 2026
+16 −1
Merged

Fix fuzzing with stream<char> #2446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/wit-smith/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ log = { workspace = true }
semver = { workspace = true }
wit-component = { workspace = true }
wit-parser = { workspace = true }
wasmparser = { workspace = true }
15 changes: 14 additions & 1 deletion crates/wit-smith/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,18 @@ pub fn smith(config: &Config, u: &mut Unstructured<'_>) -> Result<Vec<u8>> {
}
let pkg = last.unwrap();

Ok(wit_component::encode(&resolve, pkg).expect("failed to encode WIT document"))
let wasm = wit_component::encode(&resolve, pkg).expect("failed to encode WIT document");

// Handle disallowing `stream<char>` here vs not generating it to start
// with as it's a bit easier to handle.
if let Err(e) = wasmparser::Validator::new_with_features(wasmparser::WasmFeatures::all())
.validate_all(&wasm)
{
if e.to_string()
.contains("`stream<char>` is not valid at this time")
{
return Err(arbitrary::Error::IncorrectFormat);
}
}
Ok(wasm)
}
Loading