Merge the wasi-tls crates into a single one with feature flags#12780
Open
badeend wants to merge 1 commit intobytecodealliance:mainfrom
Open
Merge the wasi-tls crates into a single one with feature flags#12780badeend wants to merge 1 commit intobytecodealliance:mainfrom
badeend wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
1c13fba to
bc8d0c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines the wasi-tls crates back into a single crate with feature flags.
The current setup was never the desired state, but was a workaround to make CI work back when
nativetlssupport was first added:In this PR I work around the cross-compilation issue by simply not testing
wasi-tlsinrun-tests.pyat all. Testingwasi-tlsis now handled by a dedicated CI job.This change effectively abandons the
wasmtime-wasi-tls-nativetls&wasmtime-wasi-tls-opensslcrates on crates.io. Don't know if this need to be communicated somehow?