Skip to content

ws pool: use ws queue in as_runner#46

Merged
c-cube merged 6 commits intomainfrom
simon/improve-ws-pool
Mar 25, 2026
Merged

ws pool: use ws queue in as_runner#46
c-cube merged 6 commits intomainfrom
simon/improve-ws-pool

Conversation

@c-cube
Copy link
Copy Markdown
Owner

@c-cube c-cube commented Mar 24, 2026

see if it helps.

@c-cube c-cube marked this pull request as ready for review March 24, 2026 21:14
@gasche
Copy link
Copy Markdown

gasche commented Mar 24, 2026

Yes, this PR seems to help. I measure like this:

# on main
$ /bin/time timeout 6 sh bench_fib.sh -psize 4 -n 40 -cutoff 8 -kind pool -await
compute fib 40 using await with pool size=Some 4
git checkout improve-ws-poolCommand exited with non-zero status 124
12.57user 5.00system 0:06.33elapsed 277%CPU (0avgtext+0avgdata 2589972maxresident)k
0inputs+16outputs (0major+652285minor)pagefaults 0swaps

# on the branch
$ /bin/time timeout 6 sh bench_fib.sh -psize 4 -n 40 -cutoff 8 -kind pool -await
compute fib 40 using await with pool size=Some 4
fib 40 = 165580141
compute fib 40 using await with pool size=Some 4
fib 40 = 165580141
compute fib 40 using await with pool size=Some 4
fib 40 = 165580141
18.33user 0.36system 0:05.09elapsed 366%CPU (0avgtext+0avgdata 41036maxresident)k
0inputs+10352outputs (0major+40478minor)pagefaults 0swaps

On main, 2589972maxresident suggests that 2GiB of memory were used in 6 seconds. On the branch, 41036maxresident suggests 41MiB.

@gasche
Copy link
Copy Markdown

gasche commented Mar 25, 2026

I think that this is good and that you should merge it :-)

@c-cube c-cube force-pushed the simon/improve-ws-pool branch from 91068e6 to dc4d171 Compare March 25, 2026 13:26
@c-cube c-cube merged commit 0d0db75 into main Mar 25, 2026
4 checks passed
@c-cube c-cube deleted the simon/improve-ws-pool branch March 29, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants