Conversation
gasche
reviewed
Mar 24, 2026
|
Yes, this PR seems to help. I measure like this: # on main
$ /bin/time timeout 6 sh bench_fib.sh -psize 4 -n 40 -cutoff 8 -kind pool -await
compute fib 40 using await with pool size=Some 4
git checkout improve-ws-poolCommand exited with non-zero status 124
12.57user 5.00system 0:06.33elapsed 277%CPU (0avgtext+0avgdata 2589972maxresident)k
0inputs+16outputs (0major+652285minor)pagefaults 0swaps
# on the branch
$ /bin/time timeout 6 sh bench_fib.sh -psize 4 -n 40 -cutoff 8 -kind pool -await
compute fib 40 using await with pool size=Some 4
fib 40 = 165580141
compute fib 40 using await with pool size=Some 4
fib 40 = 165580141
compute fib 40 using await with pool size=Some 4
fib 40 = 165580141
18.33user 0.36system 0:05.09elapsed 366%CPU (0avgtext+0avgdata 41036maxresident)k
0inputs+10352outputs (0major+40478minor)pagefaults 0swapsOn main, |
|
I think that this is good and that you should merge it :-) |
91068e6 to
dc4d171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see if it helps.