Update IntType with_divider() function to resolve issue with divider being calculated incorrectly (Fixes #9)#10
Open
krcook wants to merge 2 commits intoc0fec0de:mainfrom
Open
Update IntType with_divider() function to resolve issue with divider being calculated incorrectly (Fixes #9)#10krcook wants to merge 2 commits intoc0fec0de:mainfrom
krcook wants to merge 2 commits intoc0fec0de:mainfrom
Conversation
Update types.py changing IntType:with_divider() function such that the new divider is calculated by dividing one multiplier by the other (rather than multiplying)
krcook
changed the title
krcook
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change calculation of new divider to be the dividers divided by each other, rather than multiplied
Fixes #9