Skip to content

Comments

Mark 'sign_tags' as a boolean value#263

Open
julien-lecomte wants to merge 1 commit intoc4urself:masterfrom
julien-lecomte:fix-tags-no-sign
Open

Mark 'sign_tags' as a boolean value#263
julien-lecomte wants to merge 1 commit intoc4urself:masterfrom
julien-lecomte:fix-tags-no-sign

Conversation

@julien-lecomte
Copy link

When passed as a command line option, --(no-)sign-tags is a boolean. When only taken from the configuration, it's a string.

Because of this, string "false" later evaluate to true and signing is attempted and fails.

Working configuration:

[bumpversion]
current_version = 0.2.8
commit = true
tag = true
message = Bump version from {current_version} to {new_version}
tag_message = Release version {new_version} (previous: {current_version})

[bumpversion:file:pyproject.toml]

Broken configuration:

[bumpversion]
current_version = 0.2.8
commit = true
tag = true
sign_tags = false
message = Bump version from {current_version} to {new_version}
tag_message = Release version {new_version} (previous: {current_version})

[bumpversion:file:pyproject.toml]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant