fix(website-e2e): assert differentiator section by stable id#358
Merged
Conversation
…le heading copy Landing page copy changed (heading no longer reads 'Built for Angular, not retrofitted.') but the section's id stayed (id=differentiator-heading in apps/website/src/components/landing/Differentiator.tsx). Test was failing on main. Stable-id selectors are also what the other landing-page checks in this file use (#hero-heading, #stream-heading, #render-heading, #ship-heading).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tiny test-only fix. The website e2e spec asserts a landing-page differentiator section by an outdated heading copy ("Built for Angular, not retrofitted.") that no longer appears on the page. The section's stable id (`#differentiator-heading`) is unchanged. Switching the assertion to the id mirrors what every other landing-page check in the same file already does (`#hero-heading`, `#stream-heading`, `#render-heading`, `#ship-heading`).
Test was failing on main, blocking every open PR's `Website — e2e` check.
Test plan