fix(licensing): remove token tamper flake#385
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the flaky
licensing:testby making the tampered-token fixture deterministic.Root Cause
run-license-check.spec.tsgenerated a tampered token withvalidToken.slice(0, -1) + 'x'. Because the token is random base64url, that sometimes left the token unchanged or changed only unused trailing base64 bits in the unpadded signature segment. In those cases the decoded signature remained valid, sorunLicenseCheck()correctly returnedlicensedinstead oftampered.Change
Mutate the first character of the signature segment instead, where every bit affects the decoded signature, and assert that the generated tampered token differs from the original.
Verification
20xdirectlicensingVitest coverage runs passed after the fix.nx test licensing --coverage --skip-nx-cachepassed.nx run-many -t test --projects=chat,langgraph,ag-ui,render,a2ui,licensing,telemetry --coverage --skip-nx-cachepassed.