[codex] Restore production smoke spec#386
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the standalone Playwright production smoke spec at
apps/cockpit/e2e/production-smoke.spec.ts, which is the path invoked by the post-deploy production smoke job.Root cause
The e2e harness cleanup removed
apps/cockpit/e2e, but.github/workflows/ci.ymlstill invokesnpx playwright test apps/cockpit/e2e/production-smoke.spec.ts --reporter=list. On push tomain, that job would fail before exercising the deployed stack because the spec file is missing.Validation
git diff --check.github/workflows/ci.ymlreferencesapps/cockpit/e2e/production-smoke.spec.tsFull Playwright execution was not run locally because this worktree has no
node_modules, andnpm/npxare not available in the command environment.