Skip to content

fix(ci): stabilize production primitive smoke#391

Merged
blove merged 1 commit into
mainfrom
codex/fix-production-smoke-debug-route
May 17, 2026
Merged

fix(ci): stabilize production primitive smoke#391
blove merged 1 commit into
mainfrom
codex/fix-production-smoke-debug-route

Conversation

@blove
Copy link
Copy Markdown
Contributor

@blove blove commented May 17, 2026

Summary

  • Replaces the primitive production smoke body-text check with route-specific component readiness selectors.
  • Treats primitive shells as loaded when their expected Angular component is attached, which covers intentionally textless or initially hidden primitive states.

Root cause

chat/debug was rendering correctly in production, but the smoke test used expect(body).not.toBeEmpty(). Playwright evaluates that through text content, and the debug route renders a valid textless custom-element shell until the launcher is opened.

Verification

  • BASE_URL=https://cockpit.cacheplane.ai EXAMPLES_URL=https://examples.cacheplane.ai node_modules/.bin/playwright test apps/cockpit/e2e/production-smoke.spec.ts -g "chat/debug loads at examples URL" --reporter=list
  • BASE_URL=https://cockpit.cacheplane.ai EXAMPLES_URL=https://examples.cacheplane.ai node_modules/.bin/playwright test apps/cockpit/e2e/production-smoke.spec.ts --reporter=list (32 passed, 3 skipped locally because OPENAI_API_KEY is not set)
  • NX_DAEMON=false node_modules/.bin/nx test cockpit --skip-nx-cache
  • git diff --check

Local note

NX_DAEMON=false node_modules/.bin/nx build cockpit --skip-nx-cache is blocked locally by Turbopack failing to resolve the Darwin lightningcss native binding from this workstation install. CI should be the build authority for the Linux environment.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cacheplane Ready Ready Preview, Comment May 17, 2026 4:02am

Request Review

@blove blove merged commit ce4472c into main May 17, 2026
16 checks passed
@blove blove deleted the codex/fix-production-smoke-debug-route branch May 17, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant