fix(ci): stabilize production primitive smoke#391
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
chat/debugwas rendering correctly in production, but the smoke test usedexpect(body).not.toBeEmpty(). Playwright evaluates that through text content, and the debug route renders a valid textless custom-element shell until the launcher is opened.Verification
BASE_URL=https://cockpit.cacheplane.ai EXAMPLES_URL=https://examples.cacheplane.ai node_modules/.bin/playwright test apps/cockpit/e2e/production-smoke.spec.ts -g "chat/debug loads at examples URL" --reporter=listBASE_URL=https://cockpit.cacheplane.ai EXAMPLES_URL=https://examples.cacheplane.ai node_modules/.bin/playwright test apps/cockpit/e2e/production-smoke.spec.ts --reporter=list(32 passed, 3 skipped locally becauseOPENAI_API_KEYis not set)NX_DAEMON=false node_modules/.bin/nx test cockpit --skip-nx-cachegit diff --checkLocal note
NX_DAEMON=false node_modules/.bin/nx build cockpit --skip-nx-cacheis blocked locally by Turbopack failing to resolve the Darwinlightningcssnative binding from this workstation install. CI should be the build authority for the Linux environment.