fix(chat): rename chat-sidenav-scrim output close → dismiss#485
Merged
Conversation
`close` is a standard DOM event name, which triggers @angular-eslint/no-output-native and fails Library lint CI. Renames the EventEmitter to `dismiss`, updates the only consumer (examples/chat/angular demo shell) and the component spec + docstring. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
blove
added a commit
that referenced
this pull request
May 20, 2026
2 tasks
blove
added a commit
that referenced
this pull request
May 21, 2026
…egy (#499) The spec imported `SendPromptAndWaitOptions` which was removed in PR #472 (harness helper consolidation), leaving a tsc error in the lint target that has been silently failing the Library — lint gate. The chat-sidenav- scrim no-output-native noise (resolved by #485) was masking it; subsequent admin-merges let it through. Two-part fix: 1. Delete the spec. Its original purpose ("locks in the type contract") was already covered by tsc itself; the deleted type meant the spec was just verifying a removed API. 2. Document the testing strategy in a header block on test-helpers.ts so future contributors know the absence of unit tests is intentional: - The 3 Playwright-dependent helpers are exercised end-to-end by the 24 cockpit cap aimock e2es in the matrix. - `startAimock` (the only helper testable without a Page) has its own aimock-runner.spec.ts in the same directory. Identified during the post-Task-#4 e2e audit (item #8). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatSidenavScrimComponent'scloseoutput todismiss.closeis a standard DOM event name, which trips@angular-eslint/no-output-nativeand was the lone error failingLibrary — lint / test / buildafter PR Mobile sidenav scrim + drawer elevation + z-index tokens #477.3 files, 8 insertions, 8 deletions.
Test plan
npx nx run chat:lint→ success (was failing on thecloseoutput).🤖 Generated with Claude Code