refactor(e2e): use @ngaf-internal/e2e-harness alias in cap specs#515
Merged
Conversation
Replaces ugly `../../../../../libs/e2e-harness/src` relative imports across 48 cap e2e files (specs + global-setup-impl) with the `@ngaf-internal/e2e-harness` path alias that's already declared in tsconfig.base.json. Each cap's e2e tsconfig now sets `baseUrl` + `paths` directly (rather than extending tsconfig.base.json) to keep playwright's TypeScript compilation scope minimal — only the harness path is exposed, not the whole base-config surface. The 24 `require.resolve(...globalTeardown)` calls in playwright.config.ts files are left as relative paths because tsconfig-paths doesn't apply at Node runtime. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
../../../../../libs/e2e-harness/srcrelative imports with the@ngaf-internal/e2e-harnesspath alias across all 25 cap e2e suites (24 cockpit + examples/chat).tsconfig.jsonvia localbaseUrl+paths(rather than extendingtsconfig.base.json) to keep Playwright's compilation surface minimal.require.resolve(...globalTeardown)calls inplaywright.config.tsstay as relative paths — tsconfig-paths doesn't apply at Node runtime.Test plan
Cockpit — e2e (*)matrix all greenexamples/chat — e2egreennpx tsc --noEmitin each e2e dir resolves the alias🤖 Generated with Claude Code