feat(cadence-matching): integration with executorclient #7504
+309
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleonoradgr
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
jakobht
approved these changes
Dec 9, 2025
Signed-off-by: edigregorio <edigregorio@uber.com>
Signed-off-by: edigregorio <edigregorio@uber.com>
Signed-off-by: edigregorio <edigregorio@uber.com>
eleonoradgr
force-pushed
the
matching-integration-I
branch
from
0395f4b to
2901729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The bean used to instantiate all the clients in cadence-matching service is extended to provide the support of ShardDistributor executor client.
Cadence-matching engine is extended to have an executor client.
Why?
We want to support the integration of the cadence-matching service with ShardDistributor (SD) service for shard management.
To be able to do this, cadence-matching needs to report the status of its shard (tasklist), using heartbeat to SD.
This functionality is possible using the SD executor client
How did you test it?
Running matching locally and testing the change in a staging environment.
Potential risks
Failure to start the matching service in case the executor is not provided
Release notes
Documentation Changes