Open
Conversation
johangiraud
changed the title
Member
|
Should this be reviewed? |
Contributor
Author
|
I'll be glad to have you mind on the question. But since in not in the sprint, I don't ask for review. It was more because we talked about it @vinyll, and you told me it was not a problem to add PRs aside. |
davidbgk
reviewed
Mar 15, 2018
cafebabel/static/js/script.js
Outdated
|
|
||
| /* animation picto sections */ | ||
| Array.from(document.querySelectorAll('.svg-animation')).forEach(svg => { | ||
| window.addEventListener('scroll', function() { |
Contributor
There was a problem hiding this comment.
You can use window.addEventListener('scroll', () => { which is more consistent.
davidbgk
reviewed
Mar 15, 2018
cafebabel/static/js/script.js
Outdated
| /* animation picto sections */ | ||
| Array.from(document.querySelectorAll('.svg-animation')).forEach(svg => { | ||
| window.addEventListener('scroll', function() { | ||
| if (svg.getBoundingClientRect().top < 600) { |
Contributor
Author
There was a problem hiding this comment.
Yea I didn't know how to get the moment where the picto start being watched. Maybe viewportHeight will do d457cd0
vinyll
approved these changes
Mar 15, 2018
cafebabel/static/js/script.js
Outdated
|
|
||
| /* animation picto sections */ | ||
| Array.from(document.querySelectorAll('.svg-animation')).forEach(svg => { | ||
| window.addEventListener('scroll', function() { |
Member
There was a problem hiding this comment.
es6 arrow function for consistency: …,() => {
vinyll
force-pushed
the
master
branch
2 times, most recently
from
3cc4e3c to
cf999c7
Compare
vinyll
force-pushed
the
master
branch
7 times, most recently
from
056d1f6 to
8dfe1d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, I gave a first try for
svgsimple animation. Now it's working but it still need to be improved a lot