Include all.log.html enable/disable command line arg#139
Open
Include all.log.html enable/disable command line arg#139
Conversation
Collaborator
Author
|
Test Logs: Without the --all-log-html arg :: http://allure.cisco.com/ws/jhanm-sjc/cafykit/work/archive/test_cydiff_20241010-072025_p2847338/reports/index.html (all.log.html file not generated in work_dir) With the --all-log-html arg :: http://allure.cisco.com/ws/jhanm-sjc/cafykit/work/archive/test_cydiff_20241010-071940_p2846931/reports/index.html (all.log.html file generated in work_dir) |
pashupati123
approved these changes
Oct 10, 2024
| group.addoption('--cafygta', dest='cafygta', action='store_true', | ||
| help='Variable to enable cafy gta, default is False') | ||
|
|
||
| group = parser.getgroup('Generate all.log.html - Enable/Disable') |
Contributor
There was a problem hiding this comment.
This is a bit of a specific group for CLI args. Also, every added arg makes it harder for users to understand the help output - is this really necessary? Could it be added as an ini config option instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include all.log.html enable/disable command line arg