Skip to content

Use timestamp column type for phinxlog if addTimestampsUseDateTime flag disabled #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasterOdin merged 3 commits into from
Dec 14, 2025
Merged

Use timestamp column type for phinxlog if addTimestampsUseDateTime flag disabled #2401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2abeec
refactor(db): Change timestamp column types to datetime
qnnp-me Dec 8, 2025
99a15c5
feat(migrations): Control timestamp column type using feature flag
qnnp-me Dec 9, 2025
b62dbf8
docs(config): Updated configuration documentation and feature flag co…
qnnp-me Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/en/configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,8 @@ For some breaking changes, Phinx offers a way to opt-out of new behavior. The fo
* ``column_null_default``: Should Phinx create columns as null by default? (default: ``true``)

Since MySQL ``TIMESTAMP`` fields do not support dates past 2038-01-19, you have the option to use ``DATETIME`` field
types for fields created by the ``addTimestamps()`` function:
types for fields created by the ``addTimestamps()`` function. This setting also affects the start_time and end_time
columns in the schema table:

* ``add_timestamps_use_datetime``: Should Phinx create created_at and updated_at fields as datetime? (default: ``false``)

Expand Down
1 change: 1 addition & 0 deletions src/Phinx/Config/FeatureFlags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class FeatureFlags
public static bool $columnNullDefault = true;
/**
* @var bool Should Phinx create datetime columns for addTimestamps instead of timestamp?
* Also affects start_time and end_time column types in schema table.
*/
public static bool $addTimestampsUseDateTime = false;

Expand Down
9 changes: 7 additions & 2 deletions src/Phinx/Db/Adapter/AbstractAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

use Exception;
use InvalidArgumentException;
use Phinx\Config\FeatureFlags;
use Phinx\Db\Table;
use Phinx\Db\Table\Column;
use Phinx\Util\Literal;
Expand Down Expand Up @@ -307,11 +308,15 @@ public function createSchemaTable(): void
'primary_key' => 'version',
];

$columnType = FeatureFlags::$addTimestampsUseDateTime
? AdapterInterface::PHINX_TYPE_DATETIME
: AdapterInterface::PHINX_TYPE_TIMESTAMP;

$table = new Table($this->getSchemaTableName(), $options, $this);
$table->addColumn('version', 'biginteger', ['null' => false])
->addColumn('migration_name', 'string', ['limit' => 100, 'default' => null, 'null' => true])
->addColumn('start_time', 'timestamp', ['default' => null, 'null' => true])
->addColumn('end_time', 'timestamp', ['default' => null, 'null' => true])
->addColumn('start_time', $columnType, ['default' => null, 'null' => true])
->addColumn('end_time', $columnType, ['default' => null, 'null' => true])
->addColumn('breakpoint', 'boolean', ['default' => false, 'null' => false])
->save();
} catch (Exception $exception) {
Expand Down