feat: add agent skill for bare implementation#127
Open
californiandreamer wants to merge 1 commit intocallstackincubator:mainfrom
Open
feat: add agent skill for bare implementation#127californiandreamer wants to merge 1 commit intocallstackincubator:mainfrom
californiandreamer wants to merge 1 commit intocallstackincubator:mainfrom
Conversation
Contributor
|
let's name the skill just |
mateusz1913
reviewed
Feb 20, 2026
| for (const filePath of pbxprojCandidates) { | ||
| const content = fs.readFileSync(filePath, 'utf8'); | ||
|
|
||
| if (content.includes('Generate licenses with LicensePlist')) { |
Collaborator
There was a problem hiding this comment.
that seems to be very weak check
to provide better check this we would need to use some pbxproj parser (e.g. ancient npm xcode package that's already used in the lib's implementation) and verify that:
- There is a
PBXShellScriptBuildPhasewith such name/title - Such
PBXShellScriptBuildPhaseis correctly linked to all requiredPBXNativeTargettargets withcom.apple.product-type.applicationproductType
| }, | ||
| { | ||
| name: 'iOS Settings.bundle Root.plist', | ||
| pass: fs.existsSync(path.join(root, 'ios', 'Settings.bundle', 'Root.plist')), |
Collaborator
There was a problem hiding this comment.
And here this is weak as well, since we don't check if the bundle is linked within actual .pbxproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the first agent skill for bare React Native integration of
react-native-legal.What’s done
skills/integrating-rn-legal-bare/SKILL.md.agents/skills/integrating-rn-legal-bare/**.claude/skills/integrating-rn-legal-bare/**agents/openai.yamlreferences/decision-tree.mdreferences/commands.mdreferences/implementation.mdreferences/validation-checklist.mdreferences/known-limitations.mdscripts/verify-bare-artifacts.mjs. It verifies:android/configexistsios/Settings.bundle/Root.plistexistsGenerate licenses with LicensePlistbuild phase exists--dev-deps-mode--include-optional-deps--transitive-deps-modeNotes
Approach
Skill structure and guidance were designed using agent-skill best practices for Codex and Claude, including progressive disclosure (SKILL.md +
references/), explicit routing/validation rules, and deterministic helper scripts.