BareExampleApp: Upgrade RN to 0.80. Use RNEF. Fix stability issues by wjaszczuk · Pull Request #71 · callstackincubator/react-native-legal

wjaszczuk · 2025-07-16T11:23:26Z

This PR:

Upgrades BareExample app React Native version to 0.80.1
Introduces RNEF to BareExample app
Adds RNEF caching mechanisms for E2E tests
Splits E2E tests into two phases. In the first phase, it builds the artefact, and in the second one, it uses it to run e2e tests
Upgrade Maestro version to 1.41.0
Removes usage of --pure-lockfile due to deprecation warnings

This PR fixes #50

changeset-bot · 2025-07-16T11:23:30Z

⚠️ No Changeset found

Latest commit: d19a2c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

wjaszczuk · 2025-07-16T13:40:43Z

I added tap on Android because I noticed that API 33 uses an additional modal window on a fresh Chrome instance. That was the reason for the test failure on API 33.

mateusz1913 · 2025-07-17T09:56:31Z

.github/workflows/test-e2e-android.yaml

+        run: yarn workspace react-native-legal-bare-example generate:legal
+        shell: bash
+
+      - name: "[WORKAROUND] run generateCodegenArtifactsFromSchema manually for example app"


Is this workaround done, because RNEF does not invoke codegen when building native part?

I tested it with and without RNEF. I spent some time fighting this bug, and @artus9033 helped me with it. It started working with this script before the build. Without it, it breaks. The build. My plan was to commit it with a workaround and then try to fix this bug in a separate context.

mateusz1913 · 2025-07-17T10:00:22Z

examples/bare-example/android/app/build.gradle

    hermesCommand = new File(["node", "--print", "require.resolve('react-native/package.json')"].execute(null, rootDir).text.trim()).getParentFile().getAbsolutePath() + "/sdks/hermesc/%OS-BIN%/hermesc"
    codegenDir = new File(["node", "--print", "require.resolve('@react-native/codegen/package.json')"].execute(null, rootDir).text.trim()).getParentFile().getAbsoluteFile()
-    cliFile = new File(["node", "--print", "require.resolve('react-native/package.json')"].execute(null, rootDir).text.trim(), 'cli.js')
+    cliFile = file("../../node_modules/@rnef/cli/dist/src/bin.js")


Could we align to previous syntax that supports any nested location of cli script?

I followed the RNEF docs, but I agree with you. It should be in the same format as the other files above.

mateusz1913 · 2025-07-17T10:01:23Z

examples/bare-example/android/build.gradle

        mavenCentral()
    }
    dependencies {
+        classpath("com.mikepenz.aboutlibraries.plugin:aboutlibraries-plugin:11.6.3")


I think this is line added by the generate command, let's remove it

…fications make things easier"

…iables like this in build.gradle in bare-example android app

…for bare-example app

szymonrybczak · 2025-07-19T09:42:51Z

.github/workflows/test-e2e-ios.yaml

+      - name: Download and Unpack APK artifact
+        run: |
+          curl -L -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -o artifact.zip "https://api.github.com/repos/${{ github.repository }}/actions/artifacts/${{ needs.build-release.outputs.artifact-id }}/zip"
+          unzip artifact.zip -d downloaded-artifacts
+          tar zxf downloaded-artifacts/app.tar.gz -C downloaded-artifacts
+          ls -l downloaded-artifacts
+          APP_PATH=$(pwd)/$(find downloaded-artifacts -name "*.app" -print -quit)
+          echo "ARTIFACT_PATH_FOR_E2E=$APP_PATH" >> $GITHUB_ENV
+        shell: bash


instead of doing custom logic you can use remote-cache command from: callstackincubator/rock#263. i'm linking the PR because it's not documented yet.

You can find the docs here now: https://www.rnef.dev/docs/cli#rnef-remote-cache-actions-and-options

Great! I'll use it

szymonrybczak · 2025-07-19T09:44:47Z

examples/bare-example/ios/ReactNativeLegalBareExample-Bridging-Header.h

@@ -0,0 +1,4 @@
+//


not needed.

I'll remove it

…ple app

…download in GH actions for e2e

wjaszczuk · 2025-07-24T11:35:01Z

I need some time to fix it. I convert it to draft

wjaszczuk requested review from artus9033, mateusz1913 and piotrski July 16, 2025 11:23

wjaszczuk force-pushed the 50-e2e-stability branch 2 times, most recently from 8192d6a to 1e0750b Compare July 16, 2025 12:17

wjaszczuk marked this pull request as ready for review July 16, 2025 13:39

mateusz1913 reviewed Jul 17, 2025

View reviewed changes

Wiktor Jaszczuk added 6 commits July 18, 2025 16:45

chore: upgrade react native to 0.80.1 for bare-example

0ba2d19

chore: use RNEF to build example app in e2e tests

bbbdd5a

chore: disable comment-bot for e2e builds

ed98fbd

chore: refresh yarn.lock

dec81f9

test: tap on "no thanks" on Android emulator if there is "Chrome noti…

61db889

…fications make things easier"

chore: use the same pattern to register cliFile variable as other var…

13257ad

…iables like this in build.gradle in bare-example android app

wjaszczuk force-pushed the 50-e2e-stability branch from e0c14bc to 13257ad Compare July 18, 2025 14:55

chore: remove a dependency added by plugin from android/build.gradle …

09a22f7

…for bare-example app

szymonrybczak reviewed Jul 19, 2025

View reviewed changes

Wiktor Jaszczuk added 5 commits July 21, 2025 11:06

chore: remove ReactNativeLegalBareExample-Bridging-Header.h from exam…

bd5985e

…ple app

chore: refresh yarn.lock

4cf49f7

fix: wrong cliFile in build.gradle

1e08b5c

chore: use npx rnef remote-cache download instead of manual artifact …

5e3897b

…download in GH actions for e2e

chore: remove autogenerated code in android version of bare-example app

1b3b071

wjaszczuk force-pushed the 50-e2e-stability branch 5 times, most recently from 812fd9a to 645ea85 Compare July 21, 2025 15:37

chore: tryfix

d19a2c6

wjaszczuk force-pushed the 50-e2e-stability branch from 645ea85 to d19a2c6 Compare July 21, 2025 15:40

wjaszczuk marked this pull request as draft July 24, 2025 11:34

mateusz1913 mentioned this pull request Aug 8, 2025

fix(#50): cache avd in e2e android workflow #92

Merged

Conversation

wjaszczuk commented Jul 16, 2025

Uh oh!

changeset-bot bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

wjaszczuk commented Jul 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

szymonrybczak Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wjaszczuk commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Jul 16, 2025 •

edited

Loading

szymonrybczak Jul 19, 2025 •

edited

Loading