Skip to content

Sync common files from Commonalities r4.2 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camara-release-automation wants to merge 1 commit into from
+1,564 −0

chore: sync common files from Commonalities r4.2

a656fed
Select commit
Loading
Failed to load commit list.
Closed

Sync common files from Commonalities r4.2 #93

chore: sync common files from Commonalities r4.2
a656fed
Select commit
Loading
Failed to load commit list.
camara-validation / CAMARA Validation failed May 7, 2026 in 0s

1 error, 36 warnings, 5 hints

Profile: standard | Branch: main | Trigger: pr

Annotations

Check failure on line 110 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Operation must document a 401 response 

[S-307] Operation is missing responses[401].

Suggestion: All secured operations must document a 401 Unauthorized response (CAMARA Design Guide section 3.2).

Check warning on line 1 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

CloudEvent type format is wrong 

[P-015] No event type enum values found in code/API_definitions/click-to-dial.yaml — subscription APIs should define EventType schemas

Suggestion: Define a named event type schema (e.g. ApiEventType) that constrains the CloudEvent `type` value via allOf, rather than inlining the enum directly in CloudEvent.properties.type.enum. See the implicit-events API template in Commonalities artifacts/api-templates/ (tracked in camaraproject/Commonalities#608).

Check warning on line 1 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

CloudEvent should be $ref, not inline 

[P-020] CloudEvent is defined inline in code/API_definitions/click-to-dial.yaml. Consume the shared schema from CAMARA_event_common.yaml via $ref instead of maintaining a local copy.

Suggestion: Replace the local CloudEvent schema with `$ref: './CAMARA_event_common.yaml#/components/schemas/CloudEvent'`, or an allOf combining the $ref with an API-specific ApiEventType schema. See implicit-events API template in Commonalities artifacts/api-templates/.

Check warning on line 56 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Operation tag not defined in tags list 

[S-222] Operation tags must be defined in global tags.

Check warning on line 110 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Operation must document a 400/422 response 

[S-318] Missing error response of either 400, 422 or 4XX.

Suggestion: Document 400 or 422 error responses for input validation (CAMARA Design Guide section 3.2).

Check warning on line 116 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Operation tag not defined in tags list 

[S-222] Operation tags must be defined in global tags.

Check warning on line 152 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Operation tag not defined in tags list 

[S-222] Operation tags must be defined in global tags.

Check warning on line 188 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Operation tag not defined in tags list 

[S-222] Operation tags must be defined in global tags.

Check warning on line 228 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Schema property must have a description 

[S-011] Property description is missing or empty: "notificationsBearerAuth.description" property must be truthy

Check warning on line 250 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

String must declare maxLength, enum, or const 

[S-312] Schema of type string must specify maxLength, enum, or const.

Suggestion: Add maxLength, enum, or const to string properties (CAMARA Design Guide section 2.2).

Check warning on line 255 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Schema name must be PascalCase 

[S-015] callId should be PascalCase (UpperCamelCase)

Check warning on line 255 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

String must declare maxLength, enum, or const 

[S-312] Schema of type string must specify maxLength, enum, or const.

Suggestion: Add maxLength, enum, or const to string properties (CAMARA Design Guide section 2.2).

Check warning on line 272 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

String must declare maxLength, enum, or const 

[S-312] Schema of type string must specify maxLength, enum, or const.

Suggestion: Add maxLength, enum, or const to string properties (CAMARA Design Guide section 2.2).

Check warning on line 320 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Schema property must have a description 

[S-011] Property description is missing or empty: "Caller" property must be truthy

Check warning on line 328 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Schema property must have a description 

[S-011] Property description is missing or empty: "Callee" property must be truthy

Check warning on line 336 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

String must declare maxLength, enum, or const 

[S-312] Schema of type string must specify maxLength, enum, or const.

Suggestion: Add maxLength, enum, or const to string properties (CAMARA Design Guide section 2.2).

Check warning on line 342 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Schema name must be PascalCase 

[S-015] sink should be PascalCase (UpperCamelCase)

Check warning on line 342 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

String must declare maxLength, enum, or const 

[S-312] Schema of type string must specify maxLength, enum, or const.

Suggestion: Add maxLength, enum, or const to string properties (CAMARA Design Guide section 2.2).

Check warning on line 377 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

String must declare maxLength, enum, or const 

[S-312] Schema of type string must specify maxLength, enum, or const.

Suggestion: Add maxLength, enum, or const to string properties (CAMARA Design Guide section 2.2).

Check warning on line 380 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

String must declare maxLength, enum, or const 

[S-312] Schema of type string must specify maxLength, enum, or const.

Suggestion: Add maxLength, enum, or const to string properties (CAMARA Design Guide section 2.2).

Check warning on line 404 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

String must declare maxLength, enum, or const 

[S-312] Schema of type string must specify maxLength, enum, or const.

Suggestion: Add maxLength, enum, or const to string properties (CAMARA Design Guide section 2.2).

Check warning on line 415 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

String must declare maxLength, enum, or const 

[S-312] Schema of type string must specify maxLength, enum, or const.

Suggestion: Add maxLength, enum, or const to string properties (CAMARA Design Guide section 2.2).

Check warning on line 427 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Schema name must be PascalCase 

[S-015] EventCTDStatusChanged should be PascalCase (UpperCamelCase)

Check warning on line 470 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Schema name must be PascalCase 

[S-015] status should be PascalCase (UpperCamelCase)

Check warning on line 482 in code/API_definitions/click-to-dial.yaml

See this annotation in the file changed.

@camara-validation camara-validation / CAMARA Validation

Schema name must be PascalCase 

[S-015] reason should be PascalCase (UpperCamelCase)
View more details on camara-validation