Skip to content

e2e-tests: Add tests for authctl set-uid/set-gid commands#1385

Merged
nooreldeenmansour merged 2 commits intomainfrom
authctl-set-uid/gid-tests
Apr 14, 2026
Merged

e2e-tests: Add tests for authctl set-uid/set-gid commands#1385
nooreldeenmansour merged 2 commits intomainfrom
authctl-set-uid/gid-tests

Conversation

@nooreldeenmansour
Copy link
Copy Markdown
Member

@nooreldeenmansour nooreldeenmansour commented Apr 2, 2026

Note

To test the GID/UID persistence after logging in, I've rebased on #1422. When #1422 is merged I can rebase again on main if needed

UDENG-9559
UDENG-9560

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.07%. Comparing base (154b428) to head (9f56a12).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
+ Coverage   80.28%   87.07%   +6.79%     
==========================================
  Files          20       93      +73     
  Lines         999     6367    +5368     
  Branches        0      111     +111     
==========================================
+ Hits          802     5544    +4742     
- Misses        197      767     +570     
- Partials        0       56      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nooreldeenmansour nooreldeenmansour force-pushed the authctl-set-uid/gid-tests branch 2 times, most recently from e841631 to ba891a5 Compare April 2, 2026 22:20
@nooreldeenmansour nooreldeenmansour marked this pull request as ready for review April 3, 2026 11:48
@nooreldeenmansour nooreldeenmansour force-pushed the authctl-set-uid/gid-tests branch from 1cc2320 to f4da882 Compare April 3, 2026 11:56
Copy link
Copy Markdown
Contributor

@adombeck adombeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

Comment thread e2e-tests/tests/authctl_user_set_uid.robot Outdated
Comment thread e2e-tests/tests/authctl_group_set_gid.robot Outdated
Comment thread e2e-tests/tests/authctl_user_set_uid.robot
@nooreldeenmansour nooreldeenmansour force-pushed the authctl-set-uid/gid-tests branch 2 times, most recently from 2f476fa to 0181ddd Compare April 6, 2026 17:17
@nooreldeenmansour nooreldeenmansour force-pushed the authctl-set-uid/gid-tests branch 2 times, most recently from bb7fb62 to ee61841 Compare April 13, 2026 05:53
Comment thread e2e-tests/tests/authctl_group_set_gid.robot Outdated
Comment thread e2e-tests/tests/authctl_group_set_gid.robot
Comment thread e2e-tests/tests/authctl_group_set_gid.robot Outdated
@nooreldeenmansour nooreldeenmansour force-pushed the authctl-set-uid/gid-tests branch from 289f537 to ccb2375 Compare April 13, 2026 17:18
Copy link
Copy Markdown
Contributor

@adombeck adombeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please remember to wait for #1422 to be merged and then rebase.

Verify that authctl can change the UID of a remote user and that the
home directory ownership is updated accordingly. After changing the
UID, the test confirms the user can still log in with the local
password.
Verify that authctl can change the GID of a remote group and that the
home directory ownership and the user's primary GID in passwd are
updated accordingly. After changing the GID, the test confirms the
user can still log in with the local password.
@nooreldeenmansour nooreldeenmansour force-pushed the authctl-set-uid/gid-tests branch from ccb2375 to 9f56a12 Compare April 14, 2026 12:08
@nooreldeenmansour nooreldeenmansour merged commit 7c32067 into main Apr 14, 2026
20 of 27 checks passed
@nooreldeenmansour nooreldeenmansour deleted the authctl-set-uid/gid-tests branch April 14, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants