CI workflow improvements#1367
Merged
roosterfish merged 7 commits intocanonical:mainfrom May 5, 2026
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflows to improve CI/security automation for the repository, including adding a zizmor workflow and adjusting when existing workflows run.
Changes:
- Add a new zizmor GitHub Actions security analysis workflow that can upload SARIF results.
- Broaden workflow/job gating conditions from
github.repository == 'canonical/microcloud'togithub.repository_owner == 'canonical'across several workflows. - Update the snap build trigger job to use a different reusable action and tighten git staging; add explicit SSH-agent key unloading.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .github/workflows/zizmor.yml | Adds zizmor-based workflow for GHA security analysis with SARIF upload permissions. |
| .github/workflows/tests.yml | Broadens CI gating to owner-based checks; switches snap build action ref and adjusts SSH key handling. |
| .github/workflows/commits.yml | Broadens gating to owner-based checks; removes CLA check step; sets workflow permissions to {}. |
| .github/workflows/codeql.yml | Broadens CodeQL job gating to owner-based checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roosterfish
requested changes
May 4, 2026
roosterfish
requested changes
May 4, 2026
Contributor
|
A fix for the linter is in #1369 |
Contributor
|
Can be rebased to unblock the merge. |
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
No other file should be altered anyway. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
roosterfish
approved these changes
May 5, 2026
roosterfish
reviewed
May 6, 2026
roosterfish
added a commit
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.