Skip to content

CodeQL improvements#1373

Merged
roosterfish merged 5 commits intocanonical:mainfrom
simondeziel:ci-improvements
May 7, 2026
Merged

CodeQL improvements#1373
roosterfish merged 5 commits intocanonical:mainfrom
simondeziel:ci-improvements

Conversation

@simondeziel
Copy link
Copy Markdown
Member

@simondeziel simondeziel commented May 6, 2026

Addresses some minor issues and also attempt to address the errors from https://github.com/canonical/microcloud/actions/runs/25415464099 where CodeQL is unable to build MicroCloud without custom instructions.

@simondeziel simondeziel changed the title Ci improvements CodeQL improvements May 6, 2026
@simondeziel simondeziel requested a review from Copilot May 6, 2026 19:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s CodeQL GitHub Actions workflow to better control execution (concurrency/permissions) and to adjust the build/setup steps used during analysis, aiming to resolve recent CodeQL run failures.

Changes:

  • Add workflow-level concurrency and default permissions: {} with job-scoped permissions.
  • Add Go-specific setup steps (setup-go, dependency artifact download) and switch to a manual Go build instead of CodeQL Autobuild.
  • Adjust CodeQL action step metadata/comments (version annotations) and extend the language matrix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/codeql.yml Outdated
Comment thread .github/workflows/codeql.yml Outdated
Comment thread .github/workflows/codeql.yml Outdated
Comment thread .github/workflows/codeql.yml Outdated
Comment thread .github/workflows/codeql.yml Outdated
Comment thread .github/workflows/codeql.yml
Comment thread .github/workflows/codeql.yml Outdated
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel force-pushed the ci-improvements branch 2 times, most recently from 2c45ba9 to e63d33f Compare May 6, 2026 19:17
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/codeql.yml Outdated
Comment thread .github/workflows/codeql.yml Outdated
@simondeziel simondeziel force-pushed the ci-improvements branch 2 times, most recently from ec1d8a1 to c2629b9 Compare May 6, 2026 20:22
@simondeziel simondeziel requested a review from Copilot May 6, 2026 20:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/codeql.yml Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/codeql.yml
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Also, move them into place instead of copying them.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel marked this pull request as ready for review May 6, 2026 21:20
@simondeziel simondeziel requested a review from roosterfish May 6, 2026 21:20
Copy link
Copy Markdown
Contributor

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roosterfish roosterfish merged commit b83108a into canonical:main May 7, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants