Skip to content

feat: make addresses indexes for orders optional#316

Closed
pablocampogo wants to merge 1 commit intomainfrom
make-new-orders-indexes-optional
Closed

feat: make addresses indexes for orders optional#316
pablocampogo wants to merge 1 commit intomainfrom
make-new-orders-indexes-optional

Conversation

@pablocampogo
Copy link
Copy Markdown
Contributor

Summary

  • Added IndexOrdersByAddresses configuration option to StateMachineConfig that controls whether secondary indexes for order lookups by seller/buyer address are created
  • When disabled, the /v1/query/orders endpoint returns an error if sellersSendAddress or buyerSendAddress filters are used
  • Default value is true (indexes enabled)

Changes

Configuration (lib/config.go)

  • Added DefaultIndexOrdersByAddresses constant
  • Added IndexOrdersByAddresses field to StateMachineConfig

State Machine (fsm/swap.go)

  • SetOrder: Conditionally creates seller/buyer secondary indexes based on config
  • cleanupStaleBuyerIndex: Skips cleanup when indexing is disabled
  • DeleteOrder: Conditionally deletes seller/buyer secondary indexes based on config

RPC Endpoint (cmd/rpc/query.go)

  • Orders: Returns descriptive error when address-based filtering is requested but indexing is disabled

@pablocampogo pablocampogo self-assigned this Feb 20, 2026
@pablocampogo
Copy link
Copy Markdown
Contributor Author

These indexes will be deleted over all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant