Conversation
There was a problem hiding this comment.
Here's a collaborative code review enhanced by AI assistance. These insights offer suggestions and patterns we've identified, though your expertise and judgment remain essential. Consider these recommendations as starting points for discussion rather than definitive solutions. You know your project best, so please adapt any suggestions to fit your specific needs and goals. We're here to support your development process.
Model: claude-sonnet-4-20250514 | Prompt Tokens: 1689 | Completion Tokens: 319
| .... | ||
| <profiles> | ||
| <profile> | ||
| <id>production</id> |
There was a problem hiding this comment.
shouldn't we add the local profile (as activated by default) as well?
Example command:
deploy --to h2 --with-mocks --dry --out "${project.basedir}/src/main/resources/schema-h2.sql"
There was a problem hiding this comment.
Good point - we can add the global elements with "deploy --to ha2...".
By not providing a profile it takes by default the global commands as they are up to now - no changes.
In addition we have the production profile which does partial overwriting of cds.build only.
Docu: "All profile elements in a POM from active profiles overwrite the global elements with the same name of the POM or extend those in case of collections"
| Using Maven profiles allows you to distinguish between builds for local development and production deployment. This flexibility is valuable in several scenarios: | ||
|
|
||
| * Generating [H2 database artifacts](../cqn-services/persistence-services#h2) for local development | ||
| * Creating database-specific artifacts for different target databases |
There was a problem hiding this comment.
we should also name the possibility to add additional Maven dependencies for production context (e.g. DwC)
| <groupId>com.sap.cds</groupId> | ||
| <artifactId>cds-maven-plugin</artifactId> | ||
| <executions> | ||
| <execution> |
There was a problem hiding this comment.
[...]
there are usually many more executions
There was a problem hiding this comment.
see prev.: partial overwriting
No description provided.