Skip to content

fix ResizeObserver not working in a popout #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muerwre wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix ResizeObserver not working in a popout #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/view/Layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,11 @@ export class LayoutInternal extends React.Component<ILayoutInternalProps, ILayou
this.layoutWindow.window = this.currentWindow;
this.layoutWindow.toScreenRectFunction = (r) => this.getScreenRect(r);

this.resizeObserver = new ResizeObserver(entries => {
requestAnimationFrame(() => {
// Spec says ResizeObserver triggers callback in the same window as the observed element,
// but it's just not true in Chrome, so, use ResizeObserver from PARENT window
const parentWindow = (this.currentDocument.defaultView ?? window);
this.resizeObserver = new parentWindow.ResizeObserver(entries => {
parentWindow.requestAnimationFrame(() => {
Copy link
Copy Markdown
Author

@muerwre muerwre Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, should call 'updateRect' before (and outside of) requestAnimationFrame, and redraw inside RAF

this.updateRect();
});
});
Expand All @@ -279,7 +282,7 @@ export class LayoutInternal extends React.Component<ILayoutInternalProps, ILayou
this.currentWindow.addEventListener("resize", () => {
this.updateRect();
});

this.resizeObserver.observe(this.currentWindow.document.documentElement);
const sourceElement = this.props.mainLayout!.getRootDiv()!;
const targetElement = this.selfRef.current!;

Expand Down