CompatHelper: bump compat for MKL in [extras] to 0.9, (keep existing compat)#110
Closed
github-actions[bot] wants to merge 2 commits intomainfrom
Closed
Conversation
carstenbauer
added a commit
that referenced
this pull request
Mar 26, 2026
…compat MKL doesn't ship 32-bit binaries, so `using MKL` is a no-op on x86. Guard MKL tests behind `mkl_is_loaded()` check instead of failing. Also bump MKL compat to include 0.9 (subsumes PR #110). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Subsumed by commit 72bf2e1 on main which bumps MKL compat to 0.9 and also fixes the x86 test failures by skipping MKL tests when MKL binaries aren't available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
MKLpackage from0.4, 0.6to0.4, 0.6, 0.9.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.