Improve PowerShell recipe completions#3082
Closed
abdalmoniem wants to merge 3 commits intocasey:masterfrom
Closed
Conversation
abdalmoniem
force-pushed
the
powershell_completions_improvement
branch
from
848f98f to
ce32a75
Compare
Extend PowerShell completions to show recipe names, arguments, descriptions, and aliases, bringing them in line with zsh completions. Change-Id: I24a00bca98124754c4857c9b25ebc3cfe260fa31 Signed-off-by: AbdAlMoniem AlHifnawy <hifnawy_moniem@hotmail.com>
Change-Id: I1394fbb9d2178b2436997decef7760fefeac103b
in powershell 5, the Test-Path function crashes if its string parameter's length is zero (empty string). this commit fixes this crash by adding a length check for $justFileLocation to short circuit the condition if $justFileLocation is empty. Change-Id: Ic5f3e8628c011cb9e5b4d6e9b60c703691e03f80
abdalmoniem
force-pushed
the
powershell_completions_improvement
branch
from
ce32a75 to
a6c623a
Compare
Owner
|
I switched to using Clap's dynamic completion engine in #3167. The new completion engine calls into the I created #2406 to track improvements to the new completion engine in one place. I think most of this works with the new completion engine, but please comment in #2406 if anything is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
PowerShellcompletions to show recipe names, arguments, descriptions, and aliases, bringing them in line withzshcompletions.also moved
use [System.Management.Automation]inside theRegister-ArgumentCompleterblock so users can do:without getting errors about use statements not being before any other statements.