Force UTF-8 with BOM for Windows PowerShell shebang recipes#3095
Open
egasato wants to merge 1 commit intocasey:masterfrom
Open
Force UTF-8 with BOM for Windows PowerShell shebang recipes#3095egasato wants to merge 1 commit intocasey:masterfrom
egasato wants to merge 1 commit intocasey:masterfrom
Conversation
Windows PowerShell (`powershell.exe`) is included in all modern Windows installs, and it's usual to leverage it when a recipe is complex enough to require basic control flow constructs (which `cmd.exe` usually lacks or it's unreadable). The default encoding (codepage) used by `conhost.exe` (Console Window Host) may vary depending on the display language and region of the system (e.g. 437 for US English, 850 for Western European languages), but it's certainly never UTF-8 (codepage 65001; still an experimental feature that has to be enabled system-wide). Forcing the UTF-8 Byte Order Mark to be present when the shebang recipe is for Windows PowerShell fixes many output encoding issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in #3094, Windows PowerShell support is not full due to encoding issues.
The default encoding (codepage) used by
conhost.exe(Console Window Host) may vary depending on the display language and region of the system (e.g. 437 for US English, 850 for Western European languages), but it's certainly never 65001 for UTF-8 (still an experimental feature). Moreover, even if UTF-8 was the default codepage, correct execution should not depend on system-wide settings that can potentially be changed.Forcing the UTF-8 Byte Order Mark to be present when the shebang recipe is for Windows PowerShell fixes most (if not all) output encoding issues.