Open
Conversation
added 5 commits
June 8, 2021 11:55
…e in regular view.
zombified
requested changes
Jul 9, 2021
Contributor
zombified
left a comment
zombified
left a comment
There was a problem hiding this comment.
This is a good start, but what they really want is the ability to see a representation of what the slide will look like when it's full screen and being viewed
right now, what this change does is bring in the slide content, but doesn't actually show the slide as it would be in full screen mode.
In the screenshot there, for example, the background images are large and the text/background relationship can't really be seen very well.
Perhaps we can specify a height/width and scale a preview to that size? Or go down a route of actually generating a rendered image that screencaps the slide as it would be viewed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.