Accelerate DynamicProxy test execution #726
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test execution has got much slower ever since I introduced a large number of test cases in
ParameterDefaultValuesTestCase. The situation can easily be improved, since the slow-down is largely due to a higher number ofpeverify.exeinvocations. Most of these aren't actually necessary, since it is the same proxy type getting generated for each test case.We could either split the test fixture in two – with only one deriving from
BasePEVerifyTestCaseand getting the tests where PEVerify should be run – or we could come up with a way to skippeverify.exefor single tests. For now, I am opting for the latter solution.I am aware that this is something of a quick fix. In the long run, it would probably make more sense to review all tests and decide which really need to be in a
BasePEVerifyTestCase-derived fixture, and which ones don't really require any IL verification. Such a review will take much more time, I'm holding that off for the moment.