Refines and tests collection create/update/delete commands#14
Closed
flyingzumwalt wants to merge 3 commits intocbeer:masterfrom
Closed
Refines and tests collection create/update/delete commands#14flyingzumwalt wants to merge 3 commits intocbeer:masterfrom
flyingzumwalt wants to merge 3 commits intocbeer:masterfrom
Conversation
flyingzumwalt
commented
Nov 18, 2015
flyingzumwalt
commented
- Builds out collection create/update/delete commands
- Adds test coverage for these and related commands (requires starting solr. It's slow, but you know -- now the code has tests)
- Moves basic_configs fixtues into basic_configs/config so that you can actually use them to create a working core (which is used by the tests to create/update collections)
- Adds a little bit of error handling
flyingzumwalt
force-pushed
the
master
branch
from
e006075 to
8a475b1
Compare
Author
|
@cbeer have you had a chance to review this? My commits are going to start accumulating again. |
flyingzumwalt
force-pushed
the
master
branch
from
8fc96c1 to
d8de2b2
Compare
This was referenced Nov 26, 2015
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.