ci: make releases atomic #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, "build and test" jobs would upload releases themselves, if they were cleared to do so. This mixing is not great from a pipeline security standpoint since the entire workflow runs with `contents: write`. It also introduces the potential for a *partial release*. If some jobs complete, but others do not, then a release will be issued without all its binaries. Make this operation more atomic by performing publishing activities in separate jobs. The publish jobs download all the artifacts and create the release.
cbs228
force-pushed
the
bugfix/ci_release_atomic
branch
from
b3c2715 to
1032de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, "build and test" jobs would upload releases themselves, if they were cleared to do so. This mixing is not great from a pipeline security standpoint since the entire workflow runs with
contents: write. It also introduces the potential for a partial release. If some jobs complete, but others do not, then a release will be issued without all its binaries.Make this operation more atomic by performing publishing activities in separate jobs. The publish jobs download all the artifacts and create the release.